[PATCH] D88517: [BasicBlockSections] Make sure that the labels for address-taken blocks are emitted after switching the seciton.

Snehasish Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 17:00:01 PDT 2020


snehasish added inline comments.


================
Comment at: llvm/test/CodeGen/X86/basic-block-sections-blockaddress.ll:28
+  ret void
+; CHECK:         .section .text,"ax", at progbits,unique,2
+; CHECK-NEXT:    .Ltmp1:
----------------
MaskRay wrote:
> snehasish wrote:
> > I think you meant to only indent the instructions, the labels should be indented less here and above?
> The excess indentation is here to satisfy the longest directive CHECK-LABEL.
Interesting, on my end I see that the indentation lines it up with the instructions below. Is this a phabricator quirk?
https://paste.pics/ABM6T


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88517/new/

https://reviews.llvm.org/D88517



More information about the llvm-commits mailing list