[PATCH] D75940: [x86][seses] Add documentation for SESES

[Matthew Riley via Phabricator via llvm-commits]

mattdr added a comment.
Herald added a subscriber: pengfei.

Blast from the past. It seems like there's still benefit in checking in this documentation, appropriately updated to reflect the fact that SESES is now actually in the tree.

But I think we should take a second look at how much detail to provide about variants of the mitigation. As it stands, we don't have solid advice for how to make the tradeoff between them, and if someone asked we'd tell them to use the defaults. Yet 50%+ of this doc is spent covering those variations.

Maybe it's enough to gesture vaguely in the direction of experimental options, but leave out the figures and discussion?



================
Comment at: llvm/docs/SpeculativeExecutionSideEffectSuppression.md:18-19
+running on the same machine. Also, the specific attacks we are concerned with
+(LVI or Load Value Injection) don't have any more targeted mitigation readily
+understood. Instead, we are using a mitigation of *any* form of speculative side
+channel we can identify.
----------------
need to update this to refer to the other LVI mitigation that's been checked in.


================
Comment at: llvm/docs/SpeculativeExecutionSideEffectSuppression.md:75
+
+The flags needed to run the pass once the patch is applied to LLVM is:
+
----------------
update wording now that SESES is committed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75940/new/

https://reviews.llvm.org/D75940