[PATCH] D88915: [flang][openacc] Switch to use TODO from D88909

[Valentin Clement via Phabricator via llvm-commits]

clementval created this revision.
clementval added a reviewer: schweitz.
Herald added subscribers: llvm-commits, jfb.
Herald added a reviewer: sscalpone.
Herald added a project: LLVM.
clementval requested review of this revision.

Use the Todo.h header file introduce in D88909 <https://reviews.llvm.org/D88909> to marke part of the lowering that are
not done yet.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88915

Files:
  flang/lib/Lower/OpenACC.cpp


Index: flang/lib/Lower/OpenACC.cpp
===================================================================
--- flang/lib/Lower/OpenACC.cpp
+++ flang/lib/Lower/OpenACC.cpp
@@ -15,13 +15,12 @@
 #include "flang/Lower/Bridge.h"
 #include "flang/Lower/FIRBuilder.h"
 #include "flang/Lower/PFTBuilder.h"
+#include "flang/Lower/Todo.h"
 #include "flang/Parser/parse-tree.h"
 #include "flang/Semantics/tools.h"
 #include "mlir/Dialect/OpenACC/OpenACC.h"
 #include "llvm/Frontend/OpenACC/ACC.h.inc"
 
-#define TODO() llvm_unreachable("not yet implemented")
-
 static const Fortran::parser::Name *
 getDesignatorNameIfDataRef(const Fortran::parser::Designator &designator) {
   const auto *dataRef{std::get_if<Fortran::parser::DataRef>(&designator.u)};
@@ -235,25 +234,31 @@
   std::visit(
       common::visitors{
           [&](const Fortran::parser::OpenACCBlockConstruct &blockConstruct) {
-            TODO();
+            TODO("OpenACC Block construct not lowered yet!");
           },
           [&](const Fortran::parser::OpenACCCombinedConstruct
-                  &combinedConstruct) { TODO(); },
+                  &combinedConstruct) {
+            TODO("OpenACC Combined construct not lowered yet!");
+          },
           [&](const Fortran::parser::OpenACCLoopConstruct &loopConstruct) {
             genACC(converter, eval, loopConstruct);
           },
           [&](const Fortran::parser::OpenACCStandaloneConstruct
-                  &standaloneConstruct) { TODO(); },
+                  &standaloneConstruct) {
+            TODO("OpenACC Standalone construct not lowered yet!");
+          },
           [&](const Fortran::parser::OpenACCRoutineConstruct
-                  &routineConstruct) { TODO(); },
+                  &routineConstruct) {
+            TODO("OpenACC Routine construct not lowered yet!");
+          },
           [&](const Fortran::parser::OpenACCCacheConstruct &cacheConstruct) {
-            TODO();
+            TODO("OpenACC Cache construct not lowered yet!");
           },
           [&](const Fortran::parser::OpenACCWaitConstruct &waitConstruct) {
-            TODO();
+            TODO("OpenACC Wait construct not lowered yet!");
           },
           [&](const Fortran::parser::OpenACCAtomicConstruct &atomicConstruct) {
-            TODO();
+            TODO("OpenACC Atomic construct not lowered yet!");
           },
       },
       accConstruct.u);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88915.296518.patch
Type: text/x-patch
Size: 2399 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201006/a6b08ac8/attachment.bin>