[PATCH] D88901: [ADT] function_ref's constructor is unavailable if the argument is not callable.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/include/llvm/ADT/STLExtras.h:193-206
+  template <typename Callable,
+            // Only allow this constructor if the object is actually callable
+            // and returns the correct type.
+            typename = typename std::enable_if<
+                std::is_void<Ret>::value ||
+                std::is_convertible<
+                    typename std::result_of<Callable(Params...)>::type,
----------------
This now has two different SFINAE approaches (one in a defaulted template type parameter, one in a defaulted function/ctor parameter) - do they need to be different? Could they be merged in some way to at least use the same/common infrastructure?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88901/new/

https://reviews.llvm.org/D88901