[PATCH] D84380: [lit] Support running tests on Windows without GnuWin32.

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

In D84380#2314645 <https://reviews.llvm.org/D84380#2314645>, @hans wrote:

> It seems confusing to me to automagically use tools that are not on PATH (or passed in explicitly as cmake flags or similar).
>
> Can't folks who want to use the git tools put them on their PATH?
>
> After this patch I think it's surprising to users why the git tools are used when e.g. the gnuwin tools are the only ones available on PATH.

I started D88850 <https://reviews.llvm.org/D88850> to make the git tools be added to the path only if other tools are not already in the path because they are failing in our setup, so the discussion has moved there. But I agree, letting the users add the tools (of their choosing) to the path themselves seems like the best option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84380/new/

https://reviews.llvm.org/D84380