[PATCH] D88697: [WebAssembly] Rename Emscripten EH functions

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 11:36:06 PDT 2020


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:229
         StringRef Name =
-            F.getFnAttribute("wasm-import-name").getValueAsString();
+            Sym->getName().startswith("invoke_")
+                ? Sym->getName()
----------------
sbc100 wrote:
> Again, this check seem fragile or at least maybe worthy of a helper like isEmscriptenInvokeWrapperName?
Sorry I missed this. Now this is using `InvokeDetected` as well, so I think it's OK now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88697/new/

https://reviews.llvm.org/D88697



More information about the llvm-commits mailing list