[PATCH] D88749: [SystemZ/z/OS] Add GOFF reader

[Yusra Syeda via Phabricator via llvm-commits]

yusra.syeda added a comment.



> It looks to me like you uploaded the wrong diff. You need to upload a diff of your entire final commit that this will be committed as, when making edits to the code. If you intend to upload a series of individual commits, and want them all reviewed together, you should create separate patches for each of them and link them together using the "edit related objects" option to create a patch series.
>
> This patch adds support for a large number of different dumping options all at once. Please break it down into separate smaller pieces. For example, your first patch could just create the GOFFDumper, and do nothing with it, the next adds section header support, the next symbol table support and so on. It is not going to be straightforward to review such a large piece of work all at once.

Thanks for the review. I will break this patch down.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88749/new/

https://reviews.llvm.org/D88749