[PATCH] D88887: [AMDGPU][MC] Improved diagnostics for instructions with missing features

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 09:39:49 PDT 2020


dp marked an inline comment as done.
dp added inline comments.


================
Comment at: llvm/test/MC/AMDGPU/gfx1030_err.s:29
 v_mac_f32 v0, v1, v2
-// GFX10: error: instruction not supported on this GPU
+// GFX10: error: operands are not valid for this GPU or mode
 
----------------
rampitec wrote:
> It does not seem right, this instruction is really unsupported.
Exactly. I've already filed a bug [47741](https://bugs.llvm.org/show_bug.cgi?id=47741).

The flag HasMadMacF32Insts is missing in dpp variant table for this opcode.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88887/new/

https://reviews.llvm.org/D88887



More information about the llvm-commits mailing list