[PATCH] D88897: [AArch64] WIP for review D88742

Vinay Madhusudan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 07:02:04 PDT 2020


mivnay added a comment.

This change seems to be generating a different pattern (UABDLv4i32_v2i64 vs UABDLv2i32_v2i64) for one of the test cases in arm64-vabs.ll. I am not sure whether the new pattern generated is correct and better.

original:

  t0: ch = EntryToken
        t2: v4i32,ch = CopyFromReg t0, Register:v4i32 %0
          t4: i32,ch = CopyFromReg t0, Register:i32 %1
        t25: v4i32 = DUPv4i32gpr t4
      t28: v2i64 = UABDLv4i32_v2i64 t2, t25
    t19: ch,glue = CopyToReg t0, Register:v2i64 $q0, t28
    t20: ch = RET_ReallyLR Register:v2i64 $q0, t19, t19:1

modified:

  t0: ch = EntryToken
    t2: v4i32,ch = CopyFromReg t0, Register:v4i32 %0
          t27: f128 = EXTv16i8 t2, t2, TargetConstant:i32<8>
        t14: v2i32 = EXTRACT_SUBREG t27, TargetConstant:i32<2>                                   
          t4: i32,ch = CopyFromReg t0, Register:i32 %1                                           
        t25: v2i32 = DUPv2i32gpr t4 
      t17: v2i64 = UABDLv2i32_v2i64 t14, t25
    t19: ch,glue = CopyToReg t0, Register:v2i64 $q0, t17
    t20: ch = RET_ReallyLR Register:v2i64 $q0, t19, t19:1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88897/new/

https://reviews.llvm.org/D88897



More information about the llvm-commits mailing list