[PATCH] D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:561-562
+                                             0, 0, 1, 0, 0, 1};
+  if (Version == 2)
+    StandardOpcodeLengths.resize(9);
+  else if (OpcodeBase)
----------------
This probably deserves a comment saying something like "DWARF v2 uses the same first 9 standard opcodes as v3-5."


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml:785-786
+
+## Infer the opcode_base and standard_opcode_lengths fields for a DWARFv2 line
+## table.
+
----------------
I suggest you do this for each of the other versions too, assuming the test is straightforward to write using FileCheck and yaml2obj -D options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88355/new/

https://reviews.llvm.org/D88355