[PATCH] D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 03:25:01 PDT 2020


jhenderson added reviewers: ajpaverd, grimar, mstorsjo.
jhenderson added a comment.
Herald added a subscriber: pengfei.

The code is still missing quite a bit of testing. Here are cases that I can see don't have any coverage:

1. No TLS directory means nothing is printed.
2. 32 versus 64 bit versions (I don't know which one is currently being tested, but they both should be).
3. The various different branches in `initTLSDirectoryPtr`, including, but not limited to, the error case.

I've also added several people who have recently touched or reviewed code in llvm-readobj as reviewers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88635/new/

https://reviews.llvm.org/D88635



More information about the llvm-commits mailing list