[PATCH] D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases"

[Andrew Ng via Phabricator via llvm-commits]

andrewng added a comment.

In D88830#2313269 <https://reviews.llvm.org/D88830#2313269>, @MaskRay wrote:

> The description can be shortened a bit. The important part is that `variableEq` returns false if two relocations reference a pair of aliased symbols in an ineligible section.

Actually, the key difference in this patch is that `variableEq` returns true for two relocations to a pair of "aliased" symbols that reference the same section which is ineligible for ICF. This patch actually came about from the investigation into the ICF link performance issue with objects compiled with `-fprofile-instr-generate`. It was during this investigation that I noticed some of these shortcomings.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88830/new/

https://reviews.llvm.org/D88830