[PATCH] D88782: [MemorySSA] Use provided memory location even if instruction is call

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/MemorySSA.cpp:2361
   Q.Inst = I;
   Q.IsCall = false;
 
----------------
asbirlea wrote:
> Is it possible this is the place where the inconsistency comes from, or did I misunderstand?
Depends on what you mean by "comes from" :) This is indeed the place where we create a Query with IsCall=false and Inst being (potentially) a CallBase. However, I believe this is correct, as this query should only care about the provided Loc, not the Inst it happens to start at. Maybe it would be possible to set Inst to nullptr altogether...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88782/new/

https://reviews.llvm.org/D88782