[PATCH] D88808: [X86] Defer the creation of LCMPXCHG16B_SAVE_RBX until finalize-isel
Pengfei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 5 22:23:17 PDT 2020
pengfei added a comment.
LGTM but I'd like to see if someone has objections.
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:33785
+ BuildMI(*BB, MI, DL, TII->get(TargetOpcode::COPY), X86::RBX)
+ .addReg(MI.getOperand(X86::AddrNumOperands).getReg());
+ X86AddressMode AM = getAddressFromInstr(&MI, 0);
----------------
Why don't we use the same form as line 33780?
================
Comment at: llvm/lib/Target/X86/X86InstrCompiler.td:891
+ (ins i128mem:$ptr, GR64:$rbx_input),
+ "cmpxchg16b\t$ptr",
+ [(X86cas16 addr:$ptr, GR64:$rbx_input)]>;
----------------
Maybe we can leave it "" since we don't use its assmebly.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88808/new/
https://reviews.llvm.org/D88808
More information about the llvm-commits
mailing list