[PATCH] D88830: [LLD][ELF] Improve ICF for relocations to sections via "aliases"
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 5 18:07:37 PDT 2020
MaskRay added inline comments.
================
Comment at: lld/ELF/ICF.cpp:227
for (size_t i = begin; i < mid; ++i)
- sections[i]->eqClass[next] = mid;
+ sections[i]->eqClass[next] = eqClass;
----------------
MaskRay wrote:
> Here this actually computes non-hash IDs. Clearing the MSB (the original code) is better.
hmm. the idea is to make this distinct from a uniqueID.
Let `uniqueId` start from inputSections.size()?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88830/new/
https://reviews.llvm.org/D88830
More information about the llvm-commits
mailing list