[PATCH] D88787: [llvm][mlir] Promote the experimental reduction intrinsics to be first class intrinsics.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 17:35:32 PDT 2020


aemerson added inline comments.


================
Comment at: llvm/docs/LangRef.rst:15597
 reduction will not preserve the associativity of an equivalent scalarized
 counterpart. Otherwise the reduction will be *ordered*, thus implying that
 the operation respects the associativity of a scalarized reduction. That is, the
----------------
spatel wrote:
> Given that we're using the term "sequential" in D88791 (and I think that's a good change), should we do the same here for consistency? That could be considered an improvement independently of removing "experimental".
Sounds like a good idea. I'll do that as a separate change after D88791 lands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88787/new/

https://reviews.llvm.org/D88787



More information about the llvm-commits mailing list