[PATCH] D88835: [llvm-readelf] - Implement --addrsig option.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 16:41:10 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4775
+  for (uint64_t Sym : *SymsOrErr) {
+    Fields[0].Str = to_string(format_decimal(++SymIndex, 6)) + ":";
+    Fields[1].Str = this->dumper().getStaticSymbolName(Sym);
----------------
Can Twine be leveraged to avoid the temporary std::string construction?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88835/new/

https://reviews.llvm.org/D88835



More information about the llvm-commits mailing list