[PATCH] D88850: [lit, windows] Fix the search for git tools on Windows to check the path first

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

In D88850#2312985 <https://reviews.llvm.org/D88850#2312985>, @amccarth wrote:

> I don't know whether Python and our config tools use the terms consistent, but `Win32` is the name of the Windows API used on both 32- and 64-bit processors, `Win16` was the API used on 16-bit machines, and `Win64` is a made-up term that confuses the issues.

Our code uses sys.platform (win32) and platform.system (windows) *both*. My assertion was that they are either the same, or not. If they are the same, we should pick one (in this file, at least) and run with it. If they are different, we should treat them as such and undo the change that to removed calling `features.add('system-windows')` in one of the cases. I don't know enough about python's APIs to be sure that there isn't an edge case, and I've certainly seen weird edge cases because of naming conventions elsewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88850/new/

https://reviews.llvm.org/D88850