[PATCH] D88629: [lld-macho] Add ARM64 target arch

[Greg McGary via Phabricator via llvm-commits]

gkm marked 2 inline comments as done.
gkm added a comment.

@smeenai and I agreed that this diff should contain a complete set of tests.



================
Comment at: lld/MachO/Arch/ARM64.cpp:127-130
+// For instruction relocations (load/store & address arithmetic),
+// r.addend contains the base encoding--opcode and non-relococatable
+// operand fields pre-populated--with the relocatable operand
+// field--BRANCH26, PAGE21, PAGEOFF12--zero-filled.
----------------
int3 wrote:
> ultra nit: I think there should be spaces around em dashes, i.e. ` -- `
> 
> also s/relococatable/relocatable/
The real problem is that there are 4(!) em dashes in one tortuous run-on sentence. I reworded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88629/new/

https://reviews.llvm.org/D88629