[PATCH] D88808: [X86] Defer the creation of LCMPXCHG16B_SAVE_RBX until finalize-isel

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 15:56:08 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ExpandPseudo.cpp:341
     // =>
-    // [E|R]BX = InArg
+    // RBX = InArg
     // actualcmpxchg Addr
----------------
I missed these comments in the other patch.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.h:759
     LCMPXCHG16_DAG,
-    LCMPXCHG8_SAVE_EBX_DAG,
     LCMPXCHG16_SAVE_RBX_DAG,
----------------
I missed this in the other patch. Hopefully its not too distracting


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88808/new/

https://reviews.llvm.org/D88808



More information about the llvm-commits mailing list