[PATCH] D87272: [lld] Buffer writes when composing a single diagnostic
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 5 14:11:42 PDT 2020
dblaikie added a comment.
(side note: raw_ostream already has buffering support - any idea why its performance is still significantly different than the extra layer of buffering on top of it? Might be a matter of enabling buffering in lld::errs() (lld::errs().SetBufferSize(N))? That'd still work with colored output without any troubles (it'd be flushed as needed on platforms where flushing is needed). I still think if there are use cases where the performance of errors matters to users - they probably should be addressed in other ways, though, such as being able to disable warnings the user isn't interested in)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87272/new/
https://reviews.llvm.org/D87272
More information about the llvm-commits
mailing list