[PATCH] D88773: Reland "[WebAssembly] Emulate v128.const efficiently""
Thomas Lively via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 5 12:54:23 PDT 2020
tlively added a comment.
In D88773#2309958 <https://reviews.llvm.org/D88773#2309958>, @hubert.reinterpretcast wrote:
> In D88773#2309949 <https://reviews.llvm.org/D88773#2309949>, @tlively wrote:
>
>> - Make initializations even more MSVC-friendly
>
> The patch description should be updated to reflect what the issue with MSVC actually was.
I think the description still applies. Were you thinking of mentioning the specific error message? "C2100: illegal indirection" doesn't seem to give any more information than is already in the description.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88773/new/
https://reviews.llvm.org/D88773
More information about the llvm-commits
mailing list