[PATCH] D84380: [lit] Support running tests on Windows without GnuWin32.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 12:51:11 PDT 2020


rnk added a comment.

In D84380#2312513 <https://reviews.llvm.org/D84380#2312513>, @stella.stamenova wrote:

> `if lit_tools_dir is not None:` works also. @rnk - Does that work on your bot also? It would be ideal to not break either setup until we can figure out why the git tools don't work for everyone.

I have no idea if lit_tools_dir is defined, but I think the tools are already on PATH, just in the wrong order. If you can make this code check PATH for the tools and then do the preprending, that would work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84380/new/

https://reviews.llvm.org/D84380



More information about the llvm-commits mailing list