[PATCH] D88629: [lld-macho] Add ARM64 target arch

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Arch/ARM64.cpp:93
+
+inline uint64_t bitField(uint64_t value, int right, int width, int left) {
+  return ((value >> right) & ((1 << width) - 1)) << left;
----------------
gkm wrote:
> int3 wrote:
> > some comments about the different arm64 instruction formats would be helpful
> Indeed. When I find the document that catalogues and names the encoding formats I will reference those.
nit: AFAIK `inline` doesn't have a major impact on the compiler's inlining decisions and isn't necessary within cpp files. OTOH we should mark this `static`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88629/new/

https://reviews.llvm.org/D88629