[PATCH] D87342: Allow targets to augment computeKnownBits with their analysis using TargetTransformInfo

Mon Oct 5 12:19:12 PDT 2020

lebedev.ri added a comment.

In D87342#2312464 <https://reviews.llvm.org/D87342#2312464>, @nikic wrote:

> I do have a concern about the general direction here: When we allowed targets to hook into InstCombine, one of the hard design constraints was that the target is only allowed to affect combines for target intrinsics, and nothing else. This patch seems to go against that restriction by allowing to replace general analysis behavior and affect otherwise target-independent folds. Maybe @spatel and @lebedev.ri have something to say regarding that.

Yep, i don't really like that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87342/new/

https://reviews.llvm.org/D87342