[PATCH] D88842: [InstCombine] inttoptr(load) -> load
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 5 12:07:29 PDT 2020
lebedev.ri added a comment.
In D88842#2312467 <https://reviews.llvm.org/D88842#2312467>, @jdoerfert wrote:
> In D88842#2312459 <https://reviews.llvm.org/D88842#2312459>, @lebedev.ri wrote:
>
>> In D88842#2312448 <https://reviews.llvm.org/D88842#2312448>, @efriedma wrote:
>>
>>> Not sure what the isUnordered() check is doing.
>>
>> This is the restriction on `combineLoadToOperationType()`.
>> Can we do this unconditionally?
>
> I think we should not do this for atomic operations if the bitwidth is potentially different. That said, I don't see an immediate reason for the type to make an impact otherwise.
The bitwidth is not different, because we've just fixed bitwidth mismatch in the fold above.
Therefore i'll make this unconditional.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88842/new/
https://reviews.llvm.org/D88842
More information about the llvm-commits
mailing list