[PATCH] D88842: [InstCombine] inttoptr(load) -> load

Mon Oct 5 11:59:42 PDT 2020

lebedev.ri added a comment.

In D88842#2312448 <https://reviews.llvm.org/D88842#2312448>, @efriedma wrote:

> I guess the idea makes sense.

Aha, finally we're getting somewhere!

> Not sure what the isUnordered() check is doing.

I'm not really sure whether or not we are okay always doing this fold.
This is the restriction on `combineLoadToOperationType()`.
Can we do this unconditionally?

> And this needs to be address-space aware.

`combineLoadToNewType()` already takes care of annotating the new load type with proper original address space, so we should be good.

================
Comment at: llvm/utils/compare-stats.py:2
+#!/usr/bin/env python3
+'''
+Compare two .stats files generated by llvm tools
----------------
efriedma wrote:
> Did you mean to include this?
Err, no

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88842/new/

https://reviews.llvm.org/D88842