[PATCH] D88807: [lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest-timeout.py`.

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 10:15:51 PDT 2020


yln added a comment.

Flaky tests are the worst! Thanks for working on this :)

I think the principled way here would be to have two separate lit invocations for timeout fail/pass:

  not lit --timeout=1 infinite_hang.py
  # Will hang for 1 second, then aborted by timeout.
  
  lit --timeout=999 short.py
  # Will take however long it takes to do `short.py`, then pass. 999 just means "very long timeout"
  # This will be immediate on normal hosts, and whatever time it takes on resource constrained hosts.

Or am I missing something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88807/new/

https://reviews.llvm.org/D88807



More information about the llvm-commits mailing list