[PATCH] D88791: Rename the VECREDUCE_STRICT_{FADD,FMUL} SDNodes to VECREDUCE_SEQ_{FADD,FMUL}.

Mon Oct 5 10:11:20 PDT 2020

aemerson added a comment.

In D88791#2310583 <https://reviews.llvm.org/D88791#2310583>, @nikic wrote:

>> The STRICT was causing unnecessary confusion. I think SEQ is a more accurate name for what they actually do, and the other obvious option of "ORDERED" has the issue of already having a meaning in FP contexts.
>
> Out of curiosity, what is the existing usage of "ordered" that conflicts with this one?

Ordered FP comparisons, e.g. the "oeq" condition code.

================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:1108
   /// operand is an initial scalar accumulator value, and the second operand
   /// is the vector to reduce.
+  VECREDUCE_SEQ_FADD,
----------------
RKSimon wrote:
> To avoid ambiguity - please can you add a codesnippet to the comment showing the order? Maybe something similar to relaxed variants below showing possible expansions (and maybe what the default legalizing expansion is?).
Sure, will do.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88791/new/

https://reviews.llvm.org/D88791