[PATCH] D88839: SINK: Sink instructions to the block that the current block immediately dominates.

[Changpeng Fang via Phabricator via llvm-commits]

cfang created this revision.
cfang added reviewers: maskray0, arsenm.
Herald added subscribers: kerbowa, hiraditya, nhaehnle, jvesely.
Herald added a project: LLVM.
cfang requested review of this revision.
Herald added a subscriber: wdng.

The Nearest common dominator of all users is the lowest point we could possibly sink the instruction
to. While instruction sinking approach is still empirical, performance regressions have been observed
related to register pressure. As a result, we revert to the previous approach to sink the instruction to
the earliest possible block, i.e. the block that current block immediately dominates.


https://reviews.llvm.org/D88839

Files:
  llvm/lib/Transforms/Scalar/Sink.cpp
  llvm/test/CodeGen/AMDGPU/sdiv64.ll
  llvm/test/CodeGen/AMDGPU/srem64.ll
  llvm/test/CodeGen/AMDGPU/urem64.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88839.296210.patch
Type: text/x-patch
Size: 16681 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201005/e0895495/attachment.bin>