[PATCH] D88585: [DebugInfo] Support representation of multiple location operands in ISel's SDDbgValue

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SDNodeDbgValue.h:28
+
+class SDDbgOperand {
+public:
----------------
Any kind of useful Doxygen comment for this class?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SDNodeDbgValue.h:96
+      llvm_unreachable("unknown kind");
+      return false;
+    }
----------------
isn't llvm_unreachable  a noreturn function? So we should delete the `return false`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88585/new/

https://reviews.llvm.org/D88585