[PATCH] D84684: [VPlan] Use VPValue def for VPInterleaveRecipe.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7328
+    unsigned j = 0;
+    for (unsigned i = 0; i < IG->getFactor(); i++)
+      if (Instruction *Member = IG->getMember(i)) {
----------------
dmgreen wrote:
> Should this be surrounded by some sort of "if it's a load IG" check?
> 
> Equally, do we need to be adding the operands for a store IG group?
Right, we only need to add VPValues for load groups, updated. I should probably also add a check that we do not add VPValues to a plan with underlying instructions/values of type void.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1065
 
+/*template <> struct simplify_type<VPMultiValue> {*/
+// using SimpleType = VPValue *;
----------------
dmgreen wrote:
> This looks left over from something.
Indeed, that should be gone now, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84684/new/

https://reviews.llvm.org/D84684