[PATCH] D88821: Fix reordering of instructions during VirtRegRewriter unbundling

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 05:26:28 PDT 2020


critson added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/splitkit-copy-bundle.mir:301
     ; VR: renamable $sgpr12_sgpr13_sgpr14_sgpr15_sgpr16_sgpr17_sgpr18_sgpr19_sgpr20_sgpr21_sgpr22_sgpr23_sgpr24_sgpr25_sgpr26_sgpr27 = SI_SPILL_S512_RESTORE %stack.0, implicit $exec, implicit $sgpr0_sgpr1_sgpr2_sgpr3, implicit $sgpr32 :: (load 64 from %stack.0, align 4, addrspace 5)
-    ; VR: renamable $sgpr16 = COPY killed renamable $sgpr20
     ; VR: renamable $sgpr15 = COPY killed renamable $sgpr19
----------------
foad wrote:
> So the bug here is that this overwrites sgpr16 before the copy from sgpr16_sgpr17?
Yes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88821/new/

https://reviews.llvm.org/D88821



More information about the llvm-commits mailing list