[PATCH] D87236: [X86][SSE2] Use smarter instruction patterns for lowering UMIN/UMAX with v8i16.

[Tom Hender via Phabricator via llvm-commits]

TomHender added a comment.

Unfortunately I couldn't get the "update_analyze_test_checks.py" script to work no matter what arguments I tried (which included --force-update, --opt-binary=T:\llvm-project\llvm\NATIVE\Debug\bin\opt.exe, different quotation mark placement and so on). Most of the time it did just nothing without any error or it would sometimes error with "ERROR: Unexpected opt name: opt.exe".

Anyway I updated the test code manually and all the cost model tests are passing now. In the transforms directory the tests "Inline/optimization-remarks-yaml.ll" and " SampleProfile/uncompressed-profile-symbol-list.ll" fail for me but I suspect that this is not because of my patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87236/new/

https://reviews.llvm.org/D87236