[PATCH] D87836: [ARM] Fold select_cc(vecreduce_[u|s][min|max], x) into VMINV or VMAXV

Mon Oct 5 02:53:56 PDT 2020

samtebbs added a comment.

In D87836#2308677 <https://reviews.llvm.org/D87836#2308677>, @dmgreen wrote:

> One last thing I thought of. Because this is pre-lowering we have to be careful with illegal types.
>
> Can you check the types are the ones we expect them to be (v16i8/v8i16/v4i32). And add some tests for v2i64 (which should be scalarized).

Thanks for noticing this. I added tests for v2i64 and it failed an assertion so I added checks for the valid vector types.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87836/new/

https://reviews.llvm.org/D87836