[PATCH] D88788: [SROA] rewritePartition()/findCommonType(): if uses have conflicting type, try getTypePartition() before falling back to largest integral use type (PR47592)
Chandler Carruth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 5 00:44:26 PDT 2020
chandlerc added a comment.
In D88788#2311004 <https://reviews.llvm.org/D88788#2311004>, @efriedma wrote:
> I guess if we're relying on the allocated type of the alloca anyway, preferring it over an integer type isn't terrible.
>
> Really, though, we should avoid relying on the allocated type where possible. Here, we could check if any of the load/store operations use a pointer type, and choose a pointer type in that case.
FWIW, both of these make lots of sense to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88788/new/
https://reviews.llvm.org/D88788
More information about the llvm-commits
mailing list