[PATCH] D88706: [OpenMP][MLIR] WIP : Fix for nested parallel region

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 4 23:02:20 PDT 2020


SouraVX added inline comments.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:724
   }
+  LLVM_DEBUG({
+    for (Value *Output : Outputs)
----------------
fghanim wrote:
> These are unrelated to maintaining alloca insertion point. I don't recall back then whether these were removed completely, or added as part of other (2?) patches that were split off of this one.
This must be un-intentional! This is what asserted in first place and present in trunk.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88706/new/

https://reviews.llvm.org/D88706



More information about the llvm-commits mailing list