[PATCH] D88807: [lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest-timeout.py`.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 4 18:38:02 PDT 2020


dblaikie added inline comments.


================
Comment at: llvm/utils/lit/tests/Inputs/googletest-timeout/DummySubDir/OneTest.py:20-27
+if test_name == 'FirstTest.subTestB':
+    print('I am subTest B, I will hang')
+    while True:
+        pass
 elif test_name == 'FirstTest.subTestC':
     print('I am subTest C, I will hang')
     while True:
----------------
If these (subTestB and subTestC) do the same thing - should one of them be removed to avoid redundancy?

(and/or was the intent to keep the not-slow test, A (& one of only B or C) - if it is sufficiently less flakey?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88807/new/

https://reviews.llvm.org/D88807



More information about the llvm-commits mailing list