[PATCH] D88805: [MemCpyOpt] Use dereferenceable pointer helper

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 4 14:26:33 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

We could probably clean up the alignment handling in this pass now that the src and dest alignment of memcpy are separate.



================
Comment at: llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp:804
       if (I.mayThrow())
         return false;
     }
----------------
Not really related to this patch, but is mayThrow actually the right check?  Do we need willreturn instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88805/new/

https://reviews.llvm.org/D88805



More information about the llvm-commits mailing list