[PATCH] D88758: [DomTree] findNearestCommonDominator: assert the nodes are in tree

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar requested changes to this revision.
kuhar added a comment.
This revision now requires changes to proceed.

One remaining thing: the function documentation needs to be updated:

  If there is no such block then return nullptr.

This is obsolete, and it may be worth mentioning that A and B must have tree nodes.

Or actually, would it make sense to just make the function accept tree nodes instead of basic blocks?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88758/new/

https://reviews.llvm.org/D88758