[PATCH] D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

In D85140#2309107 <https://reviews.llvm.org/D85140#2309107>, @stephenneuendorffer wrote:

> Anyone have any concerns with this patch landing?  I'd be particularly interested if there are opinions about better ways to structure llvm/cmake/modules/LLVMProjectOptions.cmake or llvm/cmake/modules/LLVMProjectTargets.cmake

I'm mostly concerned about this change being too MLIR specific. Not everything in `add_llvm_project_options` and `add_llvm_project_targets` makes sense for every LLVM project and I'd preferred if this was broken down into smaller pieces that could be used independently rather than having this all-or-nothing functions.

Also a styling nit, this should have been `cmake/Modules`, not `cmake/modules`. The former is used only by LLVM and is a historic relic, all other projects use `cmake/Modules` which is more common in CMake-based builds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85140/new/

https://reviews.llvm.org/D85140