[PATCH] D88791: Rename the VECREDUCE_STRICT_{FADD,FMUL} SDNodes to VECREDUCE_SEQ_{FADD,FMUL}.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 4 01:09:14 PDT 2020


RKSimon added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:1108
   /// operand is an initial scalar accumulator value, and the second operand
   /// is the vector to reduce.
+  VECREDUCE_SEQ_FADD,
----------------
To avoid ambiguity - please can you add a codesnippet to the comment showing the order? Maybe something similar to relaxed variants below showing possible expansions (and maybe what the default legalizing expansion is?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88791/new/

https://reviews.llvm.org/D88791



More information about the llvm-commits mailing list