[PATCH] D88791: Rename the VECREDUCE_STRICT_{FADD,FMUL} SDNodes to VECREDUCE_SEQ_{FADD,FMUL}.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 3 23:22:02 PDT 2020


dmgreen added a comment.

AArch64 calls these "strictly-ordered reductions". If those two words are off the table then SEQ sounds fine to me providing we explain what that means (which we do).



================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:1111
+  VECREDUCE_SEQ_FMUL,
   /// These reductions are non-strict, and have a single vector operand.
   VECREDUCE_FADD,
----------------
-> These reductions are not strictly ordered, ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88791/new/

https://reviews.llvm.org/D88791



More information about the llvm-commits mailing list