[PATCH] D88787: [llvm][mlir] Promote the experimental reduction intrinsics to be first class intrinsics.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:3656
   }
-  case Intrinsic::experimental_vector_reduce_v2_fmul: {
+  case Intrinsic::vector_reduce_fmul: {
     SmallVector<Value *, 2> Args;
----------------
RKSimon wrote:
> Can we not just drop support for the v1 experimental fmul/fadd now? As @nikic said there is a danger of this matching against the v2 variants upgraded above as well.
Yeah I think we can probably drop support. I'll remove this special handling so we're only effectively renaming the existing set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88787/new/

https://reviews.llvm.org/D88787