[PATCH] D88787: [llvm][mlir] Promote the experimental reduction intrinsics to be first class intrinsics.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 3 13:05:56 PDT 2020


nikic added inline comments.


================
Comment at: llvm/docs/LangRef.rst:15547
+Vector Reduction Intrinsics
 ----------------------------------------
 
----------------
Underlines for titles need adjustment.


================
Comment at: llvm/test/Bitcode/upgrade-vecreduce-intrinsics.ll:74
+  ret float %res
+}
+
----------------
Please also add `fast` variants for these two tests, to make sure the operand is not replaced with 0/1 if the v2 intrinsics were used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88787/new/

https://reviews.llvm.org/D88787



More information about the llvm-commits mailing list