[PATCH] D88773: Reland "[WebAssembly] Emulate v128.const efficiently""

[Dan Weber via Phabricator via llvm-commits]

dweber added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1589-1590
+    // that actually matter so we can avoid the replace_lane in more cases.
+    std::array<uint64_t, 2> I64s({{0, 0}});
+    std::array<uint64_t, 2> ConstLaneMasks({{0, 0}});
+    size_t LaneBits = 128 / Lanes;
----------------
hubert.reinterpretcast wrote:
> tlively wrote:
> > This is the only part that has changed from the previous revision.
> MSVC doesn't work with the parens even with the extra braces.
Right. It shouldn't have parens.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88773/new/

https://reviews.llvm.org/D88773