[PATCH] D88591: [WebAssembly] Emulate v128.const efficiently

[Thomas Lively via Phabricator via llvm-commits]

tlively added a comment.

In D88591#2309812 <https://reviews.llvm.org/D88591#2309812>, @dweber wrote:

> In D88591#2308659 <https://reviews.llvm.org/D88591#2308659>, @max-kudr wrote:
>
>> Please address buildbot failure: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/19311/steps/build/logs/stdio
>>
>>   E:\build_slave\lldb-x64-windows-ninja\llvm-project\llvm\lib\Target\WebAssembly\WebAssemblyISelLowering.cpp(1589): error C2100: illegal indirection
>>   E:\build_slave\lldb-x64-windows-ninja\llvm-project\llvm\lib\Target\WebAssembly\WebAssemblyISelLowering.cpp(1590): error C2100: illegal indirection
>
> This issue is caused by VS not accepting the initializer list on the machine running the build.  It appears to be broken in VS up through   v19.24 <https://godbolt.org/z/srzjec>.  But starts working with  v19.25 <https://godbolt.org/z/jKsh8e>.  This can be resolved by using the {{0,0}} initializer syntax with std::array.

Thanks for looking into this!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88591/new/

https://reviews.llvm.org/D88591