[PATCH] D88460: Strlen loop idiom recognition

Shawn Landden via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 2 18:57:25 PDT 2020


shawnl requested changes to this revision.
shawnl added a comment.
This revision now requires changes to proceed.

This pass should recognise the nonnull attribute, as it is analyzing against null.



================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1639
+
+  // The loop exit must be conditioned on an icmp with 0.
+  // The icmp operand has to be a load on some SSA reg that increments
----------------
If the passed pointer has the "nonnull" attribute then this condition need not be present.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88460/new/

https://reviews.llvm.org/D88460



More information about the llvm-commits mailing list