[llvm] 8ae4842 - [X86] Move MWAITX_DAG ISD opcode so it is not in the strict FP range.

[Craig Topper via llvm-commits]

Author: Craig Topper
Date: 2020-10-02T18:22:02-07:00
New Revision: 8ae4842669f1fee33d22cc3f0c895c7839d05aef

URL: https://github.com/llvm/llvm-project/commit/8ae4842669f1fee33d22cc3f0c895c7839d05aef
DIFF: https://github.com/llvm/llvm-project/commit/8ae4842669f1fee33d22cc3f0c895c7839d05aef.diff

LOG: [X86] Move MWAITX_DAG ISD opcode so it is not in the strict FP range.

Add a comment to hopefully prevent anyone else from making the
same mistake.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.h

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.h b/llvm/lib/Target/X86/X86ISelLowering.h
index 7c977ce9e3fa..f8de2f7d0e79 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.h
+++ b/llvm/lib/Target/X86/X86ISelLowering.h
@@ -710,6 +710,9 @@ namespace llvm {
     // For avx512-vp2intersect
     VP2INTERSECT,
 
+    // Mwaitx builtin is lowered to this if the base pointer needs saving.
+    MWAITX_DAG,
+
     /// X86 strict FP compare instructions.
     STRICT_FCMP = ISD::FIRST_TARGET_STRICTFP_OPCODE,
     STRICT_FCMPS,
@@ -749,8 +752,8 @@ namespace llvm {
     STRICT_CVTPS2PH,
     STRICT_CVTPH2PS,
 
-    // Mwaitx builtin is lowered to this if the base pointer needs saving.
-    MWAITX_DAG,
+    // WARNING: Only add nodes here if they are stric FP nodes. Non-memory and
+    // non-strict FP nodes should be above FIRST_TARGET_STRICTFP_OPCODE.
 
     // Compare and swap.
     LCMPXCHG_DAG = ISD::FIRST_TARGET_MEMORY_OPCODE,