[PATCH] D88756: [CMake] Don't use CMakePushCheckState
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 2 17:14:16 PDT 2020
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG64f2855f15d8: [CMake] Don't use CMakePushCheckState (authored by phosek).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88756/new/
https://reviews.llvm.org/D88756
Files:
llvm/runtimes/CMakeLists.txt
Index: llvm/runtimes/CMakeLists.txt
===================================================================
--- llvm/runtimes/CMakeLists.txt
+++ llvm/runtimes/CMakeLists.txt
@@ -98,9 +98,6 @@
include(CheckLibraryExists)
include(CheckCCompilerFlag)
- include(CMakePushCheckState)
-
- cmake_push_check_state()
# We don't have libc++ (yet)...
set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} -nostdinc++ -nostdlib++")
@@ -118,7 +115,8 @@
include(HandleLLVMOptions)
include(FindPythonInterp)
- cmake_pop_check_state()
+ # Remove the -nostdlib++ option we've added earlier.
+ string(REPLACE "-nostdlib++" "" CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS}")
# Use libtool instead of ar if you are both on an Apple host, and targeting Apple.
if(CMAKE_HOST_APPLE AND APPLE)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88756.295938.patch
Type: text/x-patch
Size: 799 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201003/a16180ec/attachment.bin>
More information about the llvm-commits
mailing list